Remaining ResourceType and ConfigResourceType enum values #5154
+93
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the remaining ResourceType and ConfigResourceType enum values to achieve complete mapping between the two enums. The changes enable proper handling of broker logger and client metrics configuration resources in the Kafka admin API.
- Adds
BROKER_LOGGERandCLIENT_METRICSenum values to both ResourceType and ConfigResourceType - Implements bidirectional mapping functions between the two enum types
- Updates example code to support the new resource types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/rdkafka_admin.h | Adds new ConfigResourceType enum values and function declaration |
| src/rdkafka_admin.c | Implements mapping functions and name resolution for new resource types |
| src/rdkafka.h | Adds new ResourceType enum values with high integer mapping |
| examples/incremental_alter_configs.c | Updates example to handle new resource type strings |
airlock-confluentinc
bot
force-pushed
the
dev_remaining_resource_type_values
branch
2 times, most recently
from
ec624f4 to
52bb123
Compare
airlock-confluentinc
bot
force-pushed
the
dev_remaining_resource_type_values
branch
2 times, most recently
from
a9b434a to
826ac27
Compare
airlock-confluentinc
bot
force-pushed
the
dev_remaining_resource_type_values
branch
from
826ac27 to
170c074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
rd_kafka_ResourceType_tis used for both ACLs and Config APIs in current major version, the values ofConfigResourceTypethat aren't present inResourceTypeare mapped to higher integer values.